Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Dockerfile used for development #2575

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Mar 26, 2024

Changes / Features implemented

  • Enhance docker-compose.yaml to use the same docker/onadata-uwsgi/Dockerfile.ubuntu Dockerfile used for building the production image
  • Add multi-stage builds docker/onadata-uwsgi/Dockerfile.ubuntu to avoid running some stages unnecessary for development

Steps taken to verify this change does what is intended

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

enhance docker-compose.yaml to use the same Dockerfile used for building the production image
@kelvin-muchiri kelvin-muchiri merged commit 45283d6 into main Mar 26, 2024
9 checks passed
@kelvin-muchiri kelvin-muchiri deleted the enhance-docker-dev branch March 26, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants